added borderImageOutset to unitless CSS properties #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://drafts.csswg.org/css-backgrounds-3/#border-image-outset it supports both number and length values. Always applying ‘px’ might in that case perhaps return unwanted behavior.
|
Cool, doing a bit of planning so not merging this very second but I think we should get this into 15. |
|
I guess not many people even use this property actually, but as it is not a big deal it would make sense to add it, thank you :) |
zpao
added a commit
that referenced
this pull request
Mar 11, 2016
added borderImageOutset to unitless CSS properties
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this property and ran into a problem using it as React automatically adds the
pxunit to it.According to https://drafts.csswg.org/css-backgrounds-3/#border-image-outset it supports both number and length values.
Always applying
pxtherefore might in that case perhaps return unwanted behavior.